-
Notifications
You must be signed in to change notification settings - Fork 4
feat: support MorphTx v2 with EIP-7702 authorization lists #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panos-xyz
wants to merge
5
commits into
main
Choose a base branch
from
feat/morphtx-v2-eip7702
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5b6c2d8
feat: support MorphTx v2 with EIP-7702 authorization lists
panos-xyz 8f9f37c
chore(deps): bump rustls to 0.23.45 for RUSTSEC-2026-0285
panos-xyz da3d048
fix: address review feedback on MorphTx v2
panos-xyz f72e4cd
feat(rpc): derive the MorphTx version from the request content
panos-xyz 9a86dde
refactor: rename the Onyx hardfork to Celadon
panos-xyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not infer V2 from an empty authorization list.
self.authorization_list.is_some()also matchesSome(vec![]). A Morph statetest with an empty list and no explicit version therefore becomes V2 and receives0x7f || 0x02fallback encoding.Check that the list is non-empty. This also keeps statetest conversion consistent with the RPC conversion and the PR objective.
Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If "authorizationList" appears in the same file, it is judged as 0x04, and if "access list" appears, it is judged as │
│ V2(Major) │ 2930. V0/V1 should not carry this field, and explicitly writing [] in the fixture can only mean an empty list in V2. Following its modification method would instead execute as V0 and calculate L1 fee as V1, resulting in inconsistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 864
@fiamma-builder, your distinction between RPC request inference and state-test fixture semantics may be valid.I could not verify the required behavior because repository access failed during inspection. In particular, I could not confirm the unset-version behavior in
MorphTxEnv::encode_for_l1_feeor the intended statetest transaction-type rules.Please retry the repository check. I will then verify whether an explicit empty
authorizationListon a0x7fstate-test transaction must select V2 and use0x7f || 0x02encoding. The finding remains open until that verification completes.🐇
You are interacting with an AI system.