Conversation
Pin go-ethereum to the MorphTx v2 commit, activate morphTxV2Time in devnet genesis, and keep v2 envelopes intact through batch decode and derivation so empty authorization lists remain on the wire. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the pinned go-ethereum revision, adds MorphTx V2 batch round-trip coverage, and adds optional MorphTx V2 activation configuration to genesis generation. ChangesMorphTx V2 integration
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The available change context identifies no current merge-blocking issue. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
go-ethereumto2548caac(MorphTx v2 envelope0x7f || 0x02 || RLP, including emptyauthorizationList) and bump all Go modules via Makefile.morphTxV2Timeinto genesis config and set it to0on devnet so v2 is active from genesis.Test plan
go test ./common/batch ./node/derivationand genesislayer_twotestmake updateis a no-op against the pinned geth commitmake devnet-upthen send MorphTx v2 (empty list + one authorization) viaeth_sendRawTransaction, confirmeth_getTransactionByHashreturnsversion: "0x2"andauthorizationListMade with Cursor
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Chores