Skip to content

--excludeGlobs takes a space-separated list - #111

Merged
DeviaVir merged 1 commit into
motdotla:masterfrom
rkuzsma:patch-1
Jun 16, 2016
Merged

--excludeGlobs takes a space-separated list#111
DeviaVir merged 1 commit into
motdotla:masterfrom
rkuzsma:patch-1

Conversation

@rkuzsma

@rkuzsma rkuzsma commented Jun 4, 2016

Copy link
Copy Markdown
Contributor

-x or --excludeGlobs appears to take a space-separated list of files/types, not a comma-separated list.

-x or --excludeGlobs appears to take a space-separated list of files/types, not a comma-separated list.
@DeviaVir

DeviaVir commented Jun 5, 2016

Copy link
Copy Markdown
Collaborator

Hi @rkuzsma, thanks for checking this out! It might be nicer to solve https://github.com/motdotla/node-lambda/blob/master/lib/main.js#L144 instead?

@DeviaVir

Copy link
Copy Markdown
Collaborator

+1; actually a space separated list might look nicer overall, rolling with it

@DeviaVir
DeviaVir merged commit 7cf9b3a into motdotla:master Jun 16, 2016
@rkuzsma

rkuzsma commented Jun 17, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for the merge! Alternatively, I could update main.js to use node-glob to support **/*.js style syntax, which is super flexible, but it would break backwards compatibility, and potentially overkill.

@DeviaVir DeviaVir mentioned this pull request Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants