Skip to content

Feature AWS XRay SDK support #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeviaVir merged 4 commits into from
Feb 28, 2018
Merged

Feature AWS XRay SDK support #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3ea603
Add package to support AWSXRay
abetomo Feb 28, 2018
bdeb27f
Upgrade packages
abetomo Feb 28, 2018
dd3d998
Fix AWSXRay support
abetomo Feb 28, 2018
7bf7bbc
Add code to test AWSXRay support
abetomo Feb 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ const ScheduleEvents = require(path.join(__dirname, 'schedule_events'))
const S3Events = require(path.join(__dirname, 's3_events'))
const CloudWatchLogs = require(path.join(__dirname, 'cloudwatch_logs'))

const AWSXRay = require('aws-xray-sdk-core')
const createNamespace = require('continuation-local-storage').createNamespace

const maxBufferSize = 50 * 1024 * 1024

class Lambda {
Expand Down Expand Up @@ -116,7 +119,11 @@ event_sources.json and ${program.eventFile} files as needed.`)
console.log(JSON.stringify(results))
}

handler(event, context, callback)
const nameSpace = createNamespace('AWSXRay')
nameSpace.run(() => {
nameSpace.set('segment', new AWSXRay.Segment('annotations'))
handler(event, context, callback)
})

@DeviaVir DeviaVir Feb 28, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with X-Ray too much, does this change mean that everyone needs to have it enabled?

@abetomo abetomo Feb 28, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sufficient if only people using XRay are enabled.
Even if it is always enabled, there is no bad influence, so I always enabled it.

}

_runMultipleHandlers (events) {
Expand Down
Loading