Skip to content

Fix GitHub Actions workflow - #506

Merged
DeviaVir merged 3 commits into
motdotla:masterfrom
abetomo:fix_github_actions_workflow
Dec 5, 2019
Merged

Fix GitHub Actions workflow#506
DeviaVir merged 3 commits into
motdotla:masterfrom
abetomo:fix_github_actions_workflow

Conversation

@abetomo

@abetomoabetomo commented Oct 7, 2019

Copy link
Copy Markdown
Contributor
  • Fix 'run' of GitHub Actions workflow.
    • Fix because it was not working properly on Windows.
  • Add 'pull_request' to GitHub Actions event
  • Modify GitHub Actions setting from 'npm install' to 'npm ci'
  • Add confirmation of node and npm versions

Fix because it was not working properly on Windows.
@abetomo
abetomoforce-pushed the fix_github_actions_workflow branch from be4cd55 to 628a8b2CompareDecember 5, 2019 01:09
@abetomo
abetomoforce-pushed the fix_github_actions_workflow branch from a13c74a to 01c04c7CompareDecember 5, 2019 01:26
@abetomoabetomo changed the title Fix 'run' of GitHub Actions workflowFix GitHub Actions workflowDec 5, 2019
@abetomo

Copy link
Copy Markdown
ContributorAuthor

@DeviaVir Also fixed GitHub Actions test.
reference: #509 (comment)

@DeviaVir
DeviaVir merged commit 47cfa22 into motdotla:masterDec 5, 2019
@abetomo
abetomo deleted the fix_github_actions_workflow branch December 6, 2019 01:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@abetomo@DeviaVir