Skip to content

fix(_uploadExisting): fix function update errors - #575

Merged
DeviaVir merged 1 commit into
motdotla:masterfrom
abetomo:feature/fix_function_update_errors
Sep 24, 2021
Merged

fix(_uploadExisting): fix function update errors#575
DeviaVir merged 1 commit into
motdotla:masterfrom
abetomo:feature/fix_function_update_errors

Conversation

@abetomo

Copy link
Copy Markdown
Contributor

Immediately after updating the settings, Configuration.LastUpdateStatus is InProgress.
If you update the code in that state, you will get an error.
You need to update the code after the Configuration.LastUpdateStatus becomes Successful.

I've fixed it to wait until it becomes Successful.

fixes#573

@abetomoabetomo mentioned this pull request Sep 24, 2021
Immediately after updating the settings, `Configuration.LastUpdateStatus` is `InProgress`.
If you update the code in that state, you will get an error.
You need to update the code after the `Configuration.LastUpdateStatus` becomes `Successful`.
I've fixed it to wait until it becomes `Successful`.
@abetomo
abetomoforce-pushed the feature/fix_function_update_errors branch from 15f73cb to 9ce0d61CompareSeptember 24, 2021 06:29
@DeviaVir
DeviaVir merged commit 87580cb into motdotla:masterSep 24, 2021
@abetomo
abetomo deleted the feature/fix_function_update_errors branch September 25, 2021 00:23
@abetomo

Copy link
Copy Markdown
ContributorAuthor

Thank you for the merge.

@kgfelix

Copy link
Copy Markdown

Hi, do we have a date to launch a new release with this fix?

@DeviaVir

Copy link
Copy Markdown
Collaborator

https://github.com/motdotla/node-lambda/releases/tag/0.20.0

@kgfelix

Copy link
Copy Markdown

is working fine, thank you.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lambda deployment not working

3 participants

@abetomo@kgfelix@DeviaVir