Verify env vars before create sample files - #99
Merged
Conversation
Collaborator
|
@tallesh thanks for your contribution! Would you mind adding tests demonstrating it is now working correctly? |
Contributor
Author
|
@DeviaVir sure! I don't master javascript tests, but I will do some cases and commit again. Feel free for make comments and suggestions on my commits. |
Collaborator
|
+1 thanks @tallesh |
Collaborator
|
This has been added to 0.8.2 which has been released on NPM as the latest version, thanks again for your contribution! 🎊 |
Contributor
Author
|
Great! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch force node-lambda first look into env vars before create sampleFiles (context.json and event.json)
Previously, every time node-lambda run was executed, a event.json file was created even if the -j parameter was informed, for example after execute:
node-lambda run --handler test.handler -j test.jsonThe event.json file would be unnecessarily created and the test.json file would not be created. The same logic occurs if the EVENT_FILE var was defined.
To correct it, this code force node-lambda first look into env vars before create sampleFiles (context.json and event.json).