Uh oh!
There was an error while loading. Please reload this page.
Fix certain arguments not being correctly escaped or causing batch syntax error - #83
Conversation
21431c5 to
73d4bedCompareae1a178 to
d3c3a5aComparesatazor
commented
Nov 15, 2017
This PR is blocked until a bug in npm is solved regarding executables in |
cspotcode
commented
Dec 20, 2017
@satazor: I'm curious, what's the NPM bug? Do you have a link to their issue tracker? |
satazor
commented
Dec 20, 2017
I can't disclose the bug because it's also a security vulnerability. I can email you though. |
cspotcode
commented
Dec 20, 2017
Sure, I'm cspotcode@gmail.com. Thanks. |
andrew-c-tran
commented
Jan 18, 2018
Any updates to this PR? I've traced a webpack bundling warning in my electron app back to this library attempting to require spawn-sync. This PR by removing node v0.10 support, that should correct the build warning. |
satazor
commented
Jan 22, 2018
I've updated the PR. I will merge this once it becomes green and release 6.0.0. |
Codecov Report
@@ Coverage Diff @@## master #83 +/- ##
======================================
Coverage 98.8% 98.8% ======================================
Files 7 7 Lines 167 167 Branches 35 35 ======================================
Hits 165 165 Misses 2 2
Continue to review full report at Codecov.
|
f575053 to
2381dfeCompare…ch syntax error More specifically: - Fix a bug that made it impossible to escape an argument that contained quotes followed by `>` or other special chars, e.g.: `"foo|bar"`, fixes#82 - Fix a bug were a command containing `%x%` would be replaced with the contents of the `x` environment variable, fixes#51 This was resolved by using `^` to escape all meta chars. Additionally, double escaping was necessary for cmd-shim files located in `node_modules./bin/`. Also, this commit was a major overhaul: - Upgrade tooling - Upgrate project to es6 (node v4) - Fix commands as posix unix relatixe paths not working correctly - Fix `options` argument being mutated - Improve compliance with node's ENOENT errors - Improve detection of node's shell option support - Migrate project to moxystudio BREAKING CHANGE: remove support for older nodejs versions, only node >= 4 is supported Fixes#82, #51
satazor
commented
Jan 22, 2018
@cspotcode I've fixed the issue regarding the npm cmd-shim by double-escaping the windows shell meta chars. I've tested this exhaustively and it's working correctly! |
Fix certain arguments not being correctly escaped or causing batch syntax error
More specifically:
>or other special chars, e.g.:"foo|bar", fixesBad escaping when an argument has quotes followed by a pipe #82%x%would be replaced with the contents of thexenvironment variable, fixesFixes bug: unable to spawn .bat with %<environment variable>% in name #51This was resolved by using
^to escape all meta chars.Additionally, double escaping was necessary for cmd-shim files located in
node_modules./bin/.Also, this commit was a major overhaul:
optionsargument being mutatedBREAKING CHANGE: remove support for older nodejs versions, only node >= 4 is supported