Skip to content

WIP: login hostname / formSubmitURL fixup - #708

Closed
thomcc wants to merge 4 commits into
masterfrom
logins-formActionOrigin
Closed

WIP: login hostname / formSubmitURL fixup#708
thomcc wants to merge 4 commits into
masterfrom
logins-formActionOrigin

Conversation

@thomcc

@thomccthomcc commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

This still needs to

  • Expose some new errors to callers (probably)
  • Probably fix integration tests, and android/ios tests
  • Implement for the kotlin memory-only impl
  • Note in changelog
  • Possibly rename form_submit_url to form_action_origin (obviously the record field stays the same)
  • More strongly consider deduping after the automatic fixup (I have a WIP of it but it feels really sketchy)

Last two I'm not sure about so they aren't getting checkboxes for now

Fixes#695.

@thomcc

Copy link
Copy Markdown
ContributorAuthor

Closing this because it's ancient and probably won't be used without a rewrite

@thomccthomcc closed this Dec 3, 2019
@thomcc

Copy link
Copy Markdown
ContributorAuthor

Note that I'm keeping the branch open for future reference.

@rfk
rfk deleted the logins-formActionOrigin branch June 7, 2021 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix up invalid login records in the db

1 participant

@thomcc