Uh oh!
There was an error while loading. Please reload this page.
Rename places classes after feedback - #777
Merged
Merged
Conversation
grigoryk
approved these changes
Mar 14, 2019
grigoryk
left a comment
Contributor
There was a problem hiding this comment.
As the only user of these APIs, I approve this change 💃
Much better naming!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change but 0.19.0 is a dead megazord because of #775 anyway, and it was requested in slack by the only user of these types. Also the names are better.