give each cron job a name, so that they don't accumulate - #79
Merged
Conversation
| @@ -1,44 +1,51 @@ | |||
| - name: set cron mailto | |||
| cron: | |||
| name: set cron mailto | |||
There was a problem hiding this comment.
It bugs me that they can't inherit the name from the parent, but I guess that's how ansible is.
dylanwh
referenced
this pull request
in CyberShadow/bugzilla-harmony
Feb 13, 2021
…a#79) * template/en/default: Fix use_login_page The implementation fell off in 2e5d910. * template/en/default/global/ip-blocked.html.tmpl: Use use_login_page This fixes the warning "Use of uninitialized value $args[1] in join or string at .../Bugzilla/Token.pm line 270", and removes the likely-broken mini login form on the "IP blocked" page. * index.cgi: Disable use_login_page for the front page This seems to be only useful for very high-traffic installations (BMO). Co-authored-by: Dylan Hardison <dylan@hardison.net>
michaelvanstraten
pushed a commit
to michaelvanstraten/bmo
that referenced
this pull request
Nov 28, 2023
* use base to make merging with bmo easier * Revert "Bug 1497042 - Enclose table names in CREATE queries" This reverts commit 62d5637. * refactor Bugzilla::DB to not subclass DBI * use DBIx::Connector to manage database connections * Ensure we always call DBIx::Connector->dbh before any DBI method The code didn't allow a way of doing this without a lot of work. So I had to take the following approach: The 'dbh' attribute is now a method that delegates to DBIx::Connector's dbh method. Per the docs, ->dbh() "Returns the connection's database handle. It will use a an existing handle if there is one, if the process has not been forked or a new thread spawned, and if the database is pingable. Otherwise, it will instantiate, cache, and return a new handle." Then there is the matter of the 'handles' on dbh. I've used Package::Stash to insert proxy methods into the class when it is loaded. * Bug 1328659 - Add support for utf8=utf8mb4 (switches to dynamic/compressed row format, and changes charset to utf8mb4) * add deps * add prepare_cached to the list of delegated methods. This was added in bug 340160 * improve the migration to compressed/dynamic rows, skip views * add missing semicolon * remove pre-utf8mb4 emoji support * fix small issue * add debugging fatal error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No bug -- since this is just a dev environment fix.