Uh oh!
There was an error while loading. Please reload this page.
Add Bramble API for toggling whitspace view, part of mozilla/thimble.mozilla.org#1763 - continue - #702
Merged
Merged
Conversation
tonypark78force-pushed
the
thimble-issue1763
branch
from
April 11, 2017 17:52
eb4e9df to
4366675Comparetonypark78
commented
Apr 11, 2017
Author
@humphd Thank you for helping me. Please check the event parts. |
tonypark78force-pushed
the
thimble-issue1763
branch
from
April 12, 2017 04:04
4366675 to
281b768Comparehumphd
commented
Apr 13, 2017
@tonypark0403 fixed it, see humphd@766bda8. You weren't registering it with the correct preference ID. |
tonypark78force-pushed
the
thimble-issue1763
branch
from
April 13, 2017 19:52
cda7f4c to
289b502CompareAuthor
tonypark78
commented
Apr 20, 2017
Author
humphd
commented
Apr 21, 2017
This still needs review. Don't close it if you want it reviewed. |
tonypark78force-pushed
the
thimble-issue1763
branch
from
April 21, 2017 23:10
207995a to
b5070d7Comparehumphd
suggested changes
Apr 22, 2017
| exports.TOGGLE_ACTIVE_LINE = "view.toggleActiveLine"; // EditorOptionHandlers.js _getToggler() | ||
| exports.TOGGLE_WORD_WRAP = "view.toggleWordWrap"; // EditorOptionHandlers.js _getToggler() | ||
| exports.TOGGLE_ALLOW_JAVASCRIPT = "cmd.toggleAllowJavaScript"; // EditorOptionsHandlers.js _getToggler() | ||
| exports.TOGGLE_ALLOW_WHITESPACE = "cmd.toggleAllowWhiteSpace"; // EditorOptionsHandlers.js _getToggler() |
There was a problem hiding this comment.
This change is unnecessary, and does nothing. You can remove it with:
git checkout master src/command/Commands.js
| WORD_WRAP = "wordWrap", | ||
| INDENT_LINE_COMMENT = "indentLineComment", | ||
| ALLOW_JAVASCRIPT = "allowJavaScript", | ||
| ALLOW_WHITESPACE = "allowWhiteSpace", |
There was a problem hiding this comment.
Same with this file, none of these changes are necessary. Please revert them with:
git checkout master src/editor/Editor.js
tonypark78
commented
Apr 22, 2017
Author
Hello @humphd, I removed the unnecessary files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer : thimble-issue-1763
Implemented white-space-indicator.
I lost my repository by mistake.