Skip to content

Drag files out of the browser - #704

Merged
humphd merged 1 commit into
mozilla:masterfrom
humphd:drag-out-of-browser
Jun 1, 2017
Merged

Drag files out of the browser#704
humphd merged 1 commit into
mozilla:masterfrom
humphd:drag-out-of-browser

Conversation

@humphd

Copy link
Copy Markdown

This is a WIP, but I don't want to lose track of it, so I'm submitting this PR. I'll do it on top of my dnd-folders branch, when that goes in. This will need a rebase when that happens.

@Pomax
Pomax requested review from Pomax and flukeoutApril 20, 2017 20:52
@humphd
humphdforce-pushed the drag-out-of-browser branch from 650e5a1 to 5f4cec4CompareMay 8, 2017 19:45
@humphd

Copy link
Copy Markdown
Author

I've rebased this on top of master now that #659 has landed. It's ready for testing/review.

To test this:

  • Run Chrome (this only works in Chrome, though it won't crash in other browsers)
  • Drag a file from the file tree to your desktop
  • The file should appear on your desktop with the proper filename

I still have a CSS issue I can't fix. Clicking on nodes in the filetree is drawing a blue border:

blue-border

@flukeout suggested removing the box-shadow, but that doesn't seem to solve it totally for me. I could use some help figuring that out.

@Pomax

Pomax commented May 8, 2017

Copy link
Copy Markdown

code looks pretty sane to me.

@flukeout

Copy link
Copy Markdown

I think we agreed to remove this from launch since it's a fringe, hard to discover (but awesome!!) feature.

@flukeout

Copy link
Copy Markdown

@humphd Should we land this now?

@humphd
humphdforce-pushed the drag-out-of-browser branch from 5f4cec4 to e82bf0eCompareJune 1, 2017 19:00
@humphd

Copy link
Copy Markdown
Author

I rebased this, and tested again. Works well. I'll land after it passes travis.

@humphd
humphd merged commit 85ec075 into mozilla:masterJun 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@humphd@Pomax@flukeout