Skip to content

bot: replaced retry function with Tenacity - #366

Merged
marco-c merged 25 commits into
mozilla:masterfrom
seb-sojka:removeRetryFunction
Jan 28, 2020
Merged

bot: replaced retry function with Tenacity#366
marco-c merged 25 commits into
mozilla:masterfrom
seb-sojka:removeRetryFunction

Conversation

@seb-sojka

@seb-sojkaseb-sojka commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

Remove retry function and related RunException from utils.py for bot and replaces it with Tenacity retry in taskcluster.py and uploader.py
Fixes#110

marco-c
marco-c reviewed Jan 7, 2020
View reviewed changes
Comment threadbot/code_coverage_bot/taskcluster.py
marco-c
marco-c reviewed Jan 7, 2020
View reviewed changes
Comment threadbot/code_coverage_bot/taskcluster.py Outdated
@marco-c

marco-c commented Jan 7, 2020

Copy link
Copy Markdown
Collaborator

There are some linting failures (I suggest using pre-commit for that), and some test failures (you can run tests by doing cd bot and then python -m pytest -s -v tests/).

marco-c
marco-c reviewed Jan 7, 2020
View reviewed changes
Comment threadbot/requirements-dev.txt Outdated
@marco-c

marco-c commented Jan 9, 2020

Copy link
Copy Markdown
Collaborator

@seb-sojka do you still want to work on this?

marco-c
marco-c reviewed Jan 9, 2020
View reviewed changes
Comment threadbot/requirements-dev.txt Outdated
marco-c
marco-c reviewed Jan 9, 2020
View reviewed changes
Comment threadbot/code_coverage_bot/uploader.py Outdated
@seb-sojka

seb-sojka commented Jan 11, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hello,
I have run into an issue with the tester when changing to Tenacity for retries for perform_download function. It does not increase the call count but I have used print to see the perform_download occur 5 times.

marco-c
marco-c reviewed Jan 11, 2020
View reviewed changes
Comment threadbot/code_coverage_bot/utils.py Outdated
@marco-c

marco-c commented Jan 11, 2020

Copy link
Copy Markdown
Collaborator

I have run into an issue with the tester when changing to Tenacity for retries for perform_download function. It does not increase the call count but I have used print to see the perform_download occur 5 times.

Probably tenacity is not using time.sleep. You can change the test to stop mocking it, and instead count the number of times the responses URL is hit (see https://github.com/getsentry/responses, something like assert len(responses.calls) == 5).

seb-sojkaand others added 2 commits January 14, 2020 16:16
@seb-sojka
Remove the function RaiseExpection and used expection instead in util…
efbe2e9
…s.py. Updated test_taskcluster.py to check on number of times a function is called
@seb-sojka
Merge branch 'master' into removeRetryFunction
3739f47
@seb-sojka

seb-sojka commented Jan 15, 2020

Copy link
Copy Markdown
ContributorAuthor

The error with linit and taskcluster_yml. I am unsure what the solution for this. I do not have this error locally when I run the pre-commit.

marco-c
marco-c reviewed Jan 28, 2020
View reviewed changes
Comment threadbot/code_coverage_bot/uploader.py Outdated
@marco-c

marco-c commented Jan 28, 2020

Copy link
Copy Markdown
Collaborator

Looks good, just one last thing to fix!

marco-c
marco-c approved these changes Jan 28, 2020
View reviewed changes

@marco-cmarco-c left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c

marco-c commented Jan 28, 2020

Copy link
Copy Markdown
Collaborator

If you want, here are some similar issues in this and other repos:
#392
mozilla/bugbug#1234

@marco-c
marco-c merged commit 96c7b81 into mozilla:masterJan 28, 2020
@marco-cmarco-c mentioned this pull request Jan 31, 2020
Open
@aditya-hariaditya-hari mentioned this pull request Feb 4, 2020
Closed
@seb-sojka
seb-sojka deleted the removeRetryFunction branch February 9, 2020 16:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-cmarco-cmarco-c approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use tenacity (or similar) instead of re-implementing a retry function

2 participants

@seb-sojka@marco-c