Uh oh!
There was an error while loading. Please reload this page.
Bug 1970648 - Address hangs of multiple tens of seconds on pings with lots of metrics - #241
Merged
Conversation
jeddai
reviewed
Apr 13, 2026
jeddai
left a comment
Member
There was a problem hiding this comment.
Some thoughts and feedback for you, generally looks good!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
chuttenforce-pushed
the
bug1970648-perf
branch
2 times, most recently
from
April 14, 2026 19:51
c2501b8 to
c15c776Comparechutten
commented
Apr 14, 2026
ContributorAuthor
Okay, @jeddai , please tell me how I did React wrong : ) |
jeddai
commented
Apr 15, 2026
Member
Nah you did it right! |
jeddai
approved these changes
Apr 15, 2026
jeddai
left a comment
Member
There was a problem hiding this comment.
Looks good, but I still think it would be a good idea to add the previously mentioned and maybe a <br> before the button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a clever fix, but at least it's stupid.
Currently live on stage. e.g. https://glean-debug-view-dev-237806.firebaseapp.com/pings/cip/e03e226c-f409-426b-beca-db8eb8f00e18