Skip to content

Revert "Revert "chore: update deps"" - #3296

Merged
mikewilli merged 1 commit into
mainfrom
revert-3295-revert-3294-deps-20260730
Jul 31, 2026
Merged

Revert "Revert "chore: update deps""#3296
mikewilli merged 1 commit into
mainfrom
revert-3295-revert-3294-deps-20260730

Conversation

@mikewilli

Copy link
Copy Markdown
Contributor

Reverts #3295

The original change was reverted to give time to discuss the intended behavior for exposures because this change makes the default behavior different. The decision was made to go ahead with this change, as it should give us more precise information about the exposed clients, without losing anything about the current system (i.e., the enrollment and observation periods can be treated the same way).

Previous:

  • telemetry for exposed clients is filtered based on the window start/end offset from enrollment_date
  • clients are only considered "exposed" if the exposure event occurs during the enrollment period (by default, this is configurable)

After this change:

  • (different) telemetry for exposed clients is filtered based on the window start/end offset from exposure_date
  • (same) clients are only considered "exposed" if the exposure event occurs during the enrollment period (by default, this is configurable)

cc @danielkberry@irrationalagent -- this PR incorporates the bug fix from mozanalysis as we discussed

@mikewilli
mikewilli added this pull request to the merge queueJul 31, 2026
Merged via the queue into main with commit 602f2ffJul 31, 2026
4 checks passed
@mikewilli
mikewilli deleted the revert-3295-revert-3294-deps-20260730 branch July 31, 2026 20:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikewilli@scholtzan