Check build expiry in Phabricator state update - #109
Merged
Merged
Conversation
La0
marked this pull request as ready for review
November 28, 2024 13:46
Archaeopteryx
approved these changes
Jan 15, 2025
marco-c
added a commit
to marco-c/libmozevent
that referenced
this pull request
Aug 4, 2025
This reverts commit 21f855a.
marco-c
added a commit
to marco-c/libmozevent
that referenced
this pull request
Aug 4, 2025
This reverts commit 21f855a. Fixes mozilla#113
marco-c
added a commit
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs mozilla/code-review#2124
This replaces #106 by moving the expiry check in
update_statewhich is regularly called by code review events main code.A new state is used to report that a build has expired, allowing code review events to react to that state accordingly.