Uh oh!
There was an error while loading. Please reload this page.
Re-enable editing, if necessary, when exiting PresentationMode (PR 16659 follow-up) - #16675
Merged
Merged
Conversation
Snuffleupagus
commented
Jul 11, 2023
CollaboratorAuthor
/botio-linux preview |
moz-tools-bot
commented
Jul 11, 2023
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/987d932e9afcf19/output.txt |
…659 follow-up) This regressed in PR 16659, when the signature of the `PDFViewer.annotationEditorMode`-setter was changed, and it currently leads to an Error being thrown when exiting PresentationMode.
Snuffleupagusforce-pushed
the
pr-16659-followup
branch
from
July 11, 2023 20:34
ecf7257 to
7daa6b5Comparemoz-tools-bot
commented
Jul 11, 2023
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/987d932e9afcf19/output.txt Total script time: 1.44 mins Published |
calixteman
approved these changes
Jul 12, 2023
calixteman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for thinking about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed in PR #16659, when the signature of the
PDFViewer.annotationEditorMode-setter was changed, and it currently leads to an Error being thrown when exiting PresentationMode.