Skip to content

Add the possibility to create a pdf from different ones (bug 1997379) - #20409

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:split_merge_p1
Nov 7, 2025
Merged

Add the possibility to create a pdf from different ones (bug 1997379)#20409
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:split_merge_p1

Conversation

@calixteman

@calixtemancalixteman commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

For now it's just possible to create a single pdf in selecting some pages in different pdf sources. The merge is for now pretty basic (it's why it's still a WIP) none of these data are merged for now:

  • the struct trees
  • the page labels
  • the outlines
  • named destinations For there are 2 new ref tests where some new pdfs are created: one with some extracted pages and an other one (encrypted) which is just rewritten.
    The ref images are generated from the original pdfs in selecting the page we want and the new images are taken from the generated pdfs.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Oct 30, 2025
View reviewed changes
Comment threadsrc/core/editor/pdf_editor.js Fixed
@calixteman
calixtemanforce-pushed the split_merge_p1 branch 3 times, most recently from 6df136f to 9114af7CompareOctober 31, 2025 15:46
timvandermeij
timvandermeij reviewed Nov 2, 2025
View reviewed changes
Comment threadsrc/core/editor/pdf_editor.js
Comment threadsrc/core/editor/pdf_editor.js Outdated
Comment threadsrc/core/editor/pdf_editor.js Outdated
Comment threadsrc/core/editor/pdf_editor.js Outdated
Comment threadsrc/core/primitives.js
Comment threadsrc/core/worker.js Outdated
Comment threadsrc/core/writer.js
Comment threadtest/unit/api_spec.js Outdated
Comment threadtest/driver.js Outdated
Comment threadtest/test.mjs Outdated
@calixteman
calixtemanforce-pushed the split_merge_p1 branch 7 times, most recently from ff5a566 to c4f05f4CompareNovember 5, 2025 14:28
timvandermeij
timvandermeij approved these changes Nov 6, 2025
View reviewed changes

@timvandermeijtimvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the final comments addressed, WIP removed from the commit message and passing tests. Nice work!

Comment threadsrc/core/worker.js Outdated
Comment threadsrc/core/editor/pdf_editor.js Outdated
Comment threadtest/unit/api_spec.js
Comment threadtest/test_manifest.json
@calixtemancalixteman changed the title [WIP] Add the possibility to create a pdf from different ones (bug 1997379)Add the possibility to create a pdf from different ones (bug 1997379)Nov 7, 2025
@calixteman

calixteman commented Nov 7, 2025

Copy link
Copy Markdown
ContributorAuthor

/botio test

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5619354ac07dafc/output.txt

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a766a7c095d6d61/output.txt

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a766a7c095d6d61/output.txt

Total script time: 60.00 mins

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5619354ac07dafc/output.txt

Total script time: 79.13 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
 different ref/snapshot: 15

Image differences available at: http://54.193.163.58:8877/5619354ac07dafc/reftest-analyzer.html#web=eq.log

@calixteman
Add the possibility to create a pdf from different ones (bug1997379)
bc87f4e
For now it's just possible to create a single pdf in selecting some pages in different pdf sources.
The merge is for now pretty basic (it's why it's still a WIP) none of these data are merged for now:
- the struct trees
- the page labels
- the outlines
- named destinations
For there are 2 new ref tests where some new pdfs are created: one with some extracted pages and an other
one (encrypted) which is just rewritten.
The ref images are generated from the original pdfs in selecting the page we want and the new images are
taken from the generated pdfs.
@calixteman

calixteman commented Nov 7, 2025

Copy link
Copy Markdown
ContributorAuthor

The regressions are due to:
https://github.com/mozilla/pdf.js/pull/20409/files#diff-37f3ae0dc06561e4a9656a03aa4715ed4327efed309714b099070c60d397280eR149-R152
and are almost invisible.

@calixteman
calixteman merged commit 85ed401 into mozilla:masterNov 7, 2025
9 checks passed
@calixteman

calixteman commented Nov 7, 2025

Copy link
Copy Markdown
ContributorAuthor

/botio makeref

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c3d100efb509041/output.txt

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fc109caa87599fc/output.txt

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fc109caa87599fc/output.txt

Total script time: 17.83 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot

moz-tools-bot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/c3d100efb509041/output.txt

Total script time: 32.36 mins

  • Make references: Passed
  • Check references: Passed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeijtimvandermeijtimvandermeij approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixteman@moz-tools-bot@timvandermeij@github-advanced-security