Uh oh!
There was an error while loading. Please reload this page.
Pass through the implementation of more index map operations. - #364
Merged
Conversation
tromey
commented
Oct 16, 2018
Contributor
I don't really know much about this area so I think I will leave it to Nick. |
tromey
removed their request for review
October 16, 2018 19:44
coveralls
commented
Oct 16, 2018
Pull Request Test Coverage Report for Build 516
💛 - Coveralls |
fitzgen
approved these changes
Oct 18, 2018
fitzgen
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks @loganfsmyth :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexed maps have a lot of duplication with basic maps right now, and I can't see a good reason for it, so this is an effort to normalize all of that logic on top of the basic map implementation.
This PR also includes support for
computeColumnSpanson indexed maps, so that the two types of consumers have a consistent API again.Beyond the expected stuff, this PR also includes one breaking change. The basic consumer's
eachMappingfunction now returnslastGeneratedColumnasInfinityinstead ofnullwhen you've calledcomputeColumnSpansand there was no span end. Before this, it wasnull, but setting it toInfinitykeeps the API consistent withgeneratedPositionForandallGeneratedPositionsFor'slastColumnvalue.