Uh oh!
There was an error while loading. Please reload this page.
Adopt & enforce the mozilla-central Prettier config - #467
Merged
Conversation
ochameau
approved these changes
Nov 8, 2022
ochameau
left a comment
Contributor
There was a problem hiding this comment.
Thanks for jumping on this followup!
It looks good to me, there is just this one difference with m-c regarding single argument parenthesis for arrow functions.
Uh oh!
There was an error while loading. Please reload this page.
Taken from: https://searchfox.org/mozilla-central/rev/49011d374b626d5f0e7dc751a8a57365878e65f1/.prettierrc Explicitly include `arrowParens: avoid` to keep the Prettier v1 default.
eemeli
commented
Nov 9, 2022
MemberAuthor
Rebased to add |
eemeli added a commit
that referenced
this pull request
Nov 9, 2022
Taken from: https://searchfox.org/mozilla-central/rev/49011d374b626d5f0e7dc751a8a57365878e65f1/.prettierrc Explicitly include `arrowParens: avoid` to keep the Prettier v1 default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #463, this applies the current mozilla-central Prettier config to this repository, and adds a check for it in the CI.