Uh oh!
There was an error while loading. Please reload this page.
Fix an off-by-1 error in section lookup - #507
Merged
Merged
Conversation
takikawaforce-pushed
the
fix-section-lookup-off-by-one
branch
2 times, most recently
from
May 7, 2024 22:10
27daf1a to
86db47bComparebomsy
reviewed
May 28, 2024
Uh oh!
There was an error while loading. Please reload this page.
bomsy
reviewed
May 28, 2024
Uh oh!
There was an error while loading. Please reload this page.
bomsy
requested changes
May 28, 2024
bomsy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this patch. Apologies for the delay in reviews. It looks great! I've got a few review comments.
takikawaforce-pushed
the
fix-section-lookup-off-by-one
branch
from
May 28, 2024 17:07
86db47b to
3789341Comparetakikawa
commented
May 28, 2024
ContributorAuthor
Thanks for the suggestions! I've updated the patch now. |
bomsy
approved these changes
May 28, 2024
bomsy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates. LGTM!
In an indexed map, the offset line & column are stored 1-based. However, the lookup for originalPositionFor was not incrementing the 0-based column from the API argument.
takikawaforce-pushed
the
fix-section-lookup-off-by-one
branch
from
May 29, 2024 15:57
3789341 to
79aa958Comparetakikawa
commented
May 29, 2024
ContributorAuthor
There was a linter failure in CI, but should be fixed now (looks like the CI might need approval again to run). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue #506.