Skip to content

chore: remove legacy page-view migration code - #128

Open
alexs-mparticle wants to merge 1 commit into
developmentfrom
chore/remove-legacy-migration
Open

chore: remove legacy page-view migration code#128
alexs-mparticle wants to merge 1 commit into
developmentfrom
chore/remove-legacy-migration

Conversation

@alexs-mparticle

Copy link
Copy Markdown
Collaborator

Summary

Removes migrateLegacyPageViewStorage and the LEGACY_PAGE_VIEWS_KEY constant. The migration has been live since v1.33.2; migration_retry errors are < 1% of failures as of 2026-08-19. No active sessions should have the legacy mpPageViews key remaining.

  • Deleted migrateLegacyPageViewStorage export and its internal call inside loadPageViews in src/pageViewStorage.ts
  • Deleted LEGACY_PAGE_VIEWS_KEY constant and removed now-unused readJSON/removeKey imports
  • Removed the standalone migrateLegacyPageViewStorage(this.loggingService) call on the session-end path in src/Rokt-Kit.ts
  • Dropped all migrateLegacyPageViewStorage tests and the "migrates legacy key before reading" test from test/src/pageViewStorage.spec.ts
  • loadPageViews no longer takes a loggingService argument (the only use for it was the migration log); callers updated

Test plan

  • Lint and build pass
  • Monitor Datadog for migration_retry errors after this ships — should be zero

🤖 Generated with Claude Code

@alexs-mparticle
alexs-mparticleforce-pushed the chore/remove-legacy-migration branch from 1659d3a to 39fc6a7CompareAugust 20, 2026 18:37
@alexs-mparticle
alexs-mparticle marked this pull request as ready for review August 20, 2026 18:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexs-mparticle