Skip to content

Prep backend-explicit-tests for merge - #128

Merged
zejn merged 6 commits into
mpdavis:backend-explicit-testsfrom
mattsb42-aws:merge-in-master
Apr 7, 2019
Merged

Prep backend-explicit-tests for merge#128
zejn merged 6 commits into
mpdavis:backend-explicit-testsfrom
mattsb42-aws:merge-in-master

Conversation

@mattsb42-aws

@mattsb42-awsmattsb42-aws commented Apr 7, 2019

Copy link
Copy Markdown
Contributor

Given the relative number of changes, I figured it would be better to merge master into backend-explicit-tests first before merging backend-explicit-tests into master. That way the changes are smaller and more reviewable.

Next step from here will simply be merging backend-explicit-tests into master.

@mattsb42-awsmattsb42-aws changed the title Merge in masterPrep backend-explicit-tests for mergeApr 7, 2019
@codecov

codecovBot commented Apr 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #128 into backend-explicit-tests will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## backend-explicit-tests #128 +/- ##
==========================================================
- Coverage 96.53% 96.52% -0.01% 
==========================================================
Files 14 14 Lines 1068 1065 -3 ==========================================================
- Hits 1031 1028 -3 
Misses 37 37
Impacted FilesCoverage Δ
jose/jwt.py100% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5d551...3d7f084. Read the comment docs.

@zejn

zejn commented Apr 7, 2019

Copy link
Copy Markdown
Collaborator

Looks good to me.

@zejn
zejn merged commit 64cb29f into mpdavis:backend-explicit-testsApr 7, 2019
@mattsb42-aws
mattsb42-aws deleted the merge-in-master branch April 7, 2019 17:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mattsb42-aws@zejn@leplatrem@toddrme2178@mpdavis