Add "algorithm mismatch" error to improve jws - #304
Conversation
Upstream libraries that depend on `jws.verify()` break when the upstream keys contain a mixed set of algorithms. This is a nominal occurance for OIDC servers and should be properly handled.
Codecov Report
@@ Coverage Diff @@## master #304 +/- ##
==========================================
- Coverage 92.94% 92.83% -0.12%
==========================================
Files 15 15 Lines 1418 1423 +5 ==========================================
+ Hits 1318 1321 +3 - Misses 100 102 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ghost
commented
Nov 8, 2022
As mentioned in the issue, this implements step 2 of Appendix D of the JWS spec
|
dimaqq
commented
Jun 27, 2023
@mpdavis given that the original PR author account is deleted, maybe it's time to make a call: either take this PR over, maybe add more tests and merge it, or close it if it's incomplete? My 2c: this PR is a good start. |
berislavlopac
commented
Dec 19, 2024
Do we have any updates on this PR? I currently have this issue in a set up that wraps jose in several layers so it's difficult to work around it. :( |
Upstream libraries that depend on
jws.verify()break when the upstream keys contain a mixed set of algorithms. This is a nominal occurance for OIDC servers and should be properly handled.