Skip to content

Update classifiers - #87

Merged
mpdavis merged 3 commits into
mpdavis:masterfrom
hugovk:rm-eol
May 4, 2018
Merged

Update classifiers#87
mpdavis merged 3 commits into
mpdavis:masterfrom
hugovk:rm-eol

Conversation

@hugovk

Copy link
Copy Markdown
Contributor

Support for EOL Python 2.6 and 3.3 were removed in ccaff6c#diff-354f30a63fb0907d4ad57269548329e3 and 1c7691b#diff-354f30a63fb0907d4ad57269548329e3.

Update the classifiers to match.

This also modernises some code which is possible in 2.7/3.4+.

@codecov-io

codecov-io commented May 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #87 +/- ##
=======================================
Coverage 93.62% 93.62% =======================================
Files 13 13 Lines 1004 1004 =======================================
Hits 940 940 Misses 64 64
Impacted FilesCoverage Δ
jose/jwk.py95.12% <100%> (ø)⬆️
jose/constants.py100% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d568676...6d458ef. Read the comment docs.

@hugovk

Copy link
Copy Markdown
ContributorAuthor

And here's the pip installs for python-jose from PyPI for last month:

python_versionpercentdownload_count
2.790.46%195,778
3.65.68%12,298
3.52.27%4,904
3.41.57%3,402
3.70.01%19
2.60.01%18

Source: pypinfo --start-date -31 --end-date -2 --percent --pip --markdown python-jose pyversion

@zejn

zejn commented May 3, 2018

Copy link
Copy Markdown
Collaborator

Looks good to me.

@mpdavis

Copy link
Copy Markdown
Owner

lgtm

@mpdavis
mpdavis merged commit 99de7b1 into mpdavis:masterMay 4, 2018
@hugovk
hugovk deleted the rm-eol branch May 4, 2018 13:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@codecov-io@zejn@mpdavis