Conversation
Update CI workflow with explicit job names and timeouts. Pin Rust toolchain to 1.96.0. Add build steps for debug and release, ensure formatting check runs in both jobs, and use workspace-wide clippy and test commands.
Delete the GitHub Pages documentation deployment workflow. It is no longer needed since the workspace is being restructured and documentation deployment will be handled separately.
Add pull_request_body.md to .gitignore to prevent temporary PR body files from being tracked accidentally.
Replace simple Makefile with comprehensive workspace targets. Add per-crate shortcuts, publish helpers, clippy flags variable, and improved help. This improves developer workflow across the new workspace.
Add tests verifying Io error conversion via From and Metadata error source accessibility using thiserror.
Add property tests ensuring Config, PathTraversal, and Render error messages preserve their input strings.
Add comprehensive unit tests covering Display, source, From conversion, and Debug output for all error variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the CI workflow, expands the Makefile with workspace automation, and adds tests for the librawssg_error crate. It also removes an obsolete documentation deployment workflow and updates .gitignore.
Motivation & Context
The workspace restructuring requires updated CI to handle multiple crates and stricter lint settings. The Makefile needed per-crate targets and publish helpers to streamline development and release processes. Adding tests for the error crate ensures its API is reliable.
Detailed Changes
Impact & Breaking Changes
No breaking changes identified. The CI and Makefile changes are tooling-only; error crate tests are additive. Removing docs.yml only affects documentation deployment, which is not part of the library functionality.
Testing Recommendations
Run
make cito verify formatting, clippy, and full test suite. Specifically runcargo test -p librawssg_errorto execute the new error tests. Confirm CI workflow syntax by pushing to a branch or using a local validator.Related Issues
None.