HI,
when ClientSocket was closed, I think the Session._request_table were no longer necessary.
future under current strategy will be wait until timeout, but if Client set timeout None, when socket closed, there will be endless wait.
defon_close(self, sock):
# Avoid calling self.on_connect_failed after self.close called.ifself._closed:
return# if sock in self._sockets:# self._sockets.remove(sock)# self._connecting = 0# else:# Tornado does not have on_connect_failed event.self.on_connect_failed(sock)
What do you think?
HI,
when
ClientSocketwas closed, I think theSession._request_tablewere no longer necessary.futureunder current strategy will be wait until timeout, but ifClientset timeoutNone, when socket closed, there will be endless wait.What do you think?