Skip to content

Bug in header installation (root CMakeLists.txt) #782

Description

@zzxyz

When CMAKE_INSTALL_PREFIX is relative, such as "_install", headers get installed to:
./_build/_install/_install/include

I believe the correct fix is the removing ${CMAKE_INSTALL_PREFIX} since cmake should already be handling that implicitly:
FOREACH (file ${msgpackc_HEADERS})
GET_FILENAME_COMPONENT (dir ${file} PATH)
(remove) INSTALL (FILES ${file} DESTINATION ${CMAKE_INSTALL_PREFIX}/${dir})
(add) INSTALL (FILES ${file} DESTINATION ${dir})
ENDFOREACH ()

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions