Skip to content

Drop python2 support - #519

Merged
methane merged 12 commits into
msgpack:mainfrom
sblondon:drop-python2
May 21, 2023
Merged

Drop python2 support#519
methane merged 12 commits into
msgpack:mainfrom
sblondon:drop-python2

Conversation

@sblondon

Copy link
Copy Markdown
Contributor

The PR removes python2 references and cases.
tox command is green on cpython3.9 (py39-c and py39-pure) on my local machine.

Close#518

They were used to hide differences (name or behaviour) between python2 and 3. So they are not useful anymore due to the removal of python2 support.
@sblondonsblondon changed the title Drop python2Drop python2 supportSep 11, 2022
@sblondonsblondon changed the title Drop python2 supportDrop python2 support (implementation)Sep 11, 2022
Comment threadmsgpack/ext.py Outdated
Comment threadmsgpack/ext.py Outdated
datetime.timezone.utc exists since python 3.2
Comment threadmsgpack/ext.py Outdated
Comment threadmsgpack/ext.py Outdated
@methanemethane changed the title Drop python2 support (implementation)Drop python2 supportDec 6, 2022
@sblondon

Copy link
Copy Markdown
ContributorAuthor

The last commit should fix the black step error in the Github CI (https://github.com/msgpack/msgpack-python/actions/runs/3630468029/jobs/6156022655).

However, when I run black . on my system, there are several other changes (a lot of a**b modified to a ** b). They are not added to the commit in order to limit the changes. I can add them if you want.

@ThomasWaldmann

ThomasWaldmann commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

@sblondon it might depend on the black version used.

At @borgbackup, we have a version-fixed requirement in requirements.d/codestyle.txt so everybody uses exactly the same version.

At @msgpack there is also such a definition in requirements.txt, did you use it?

@sblondon

Copy link
Copy Markdown
ContributorAuthor

At @msgpack there is also such a definition in requirements.txt, did you use it?

No, I runned the black which is installed on the system, not the version defined in requirements.txt file. So the differences generated by black are not useful here: all checks (including black) are green on Github CI.

@methanemethane added this to the 1.1 milestone May 21, 2023
@methane
methane merged commit feec062 into msgpack:mainMay 21, 2023
@sblondon
sblondon deleted the drop-python2 branch May 22, 2023 21:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 2 support

3 participants

@sblondon@ThomasWaldmann@methane