Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, py27 is now officially unsupported?
I noticed a while ago that some docs still talk about py2.
Maybe there is also some code still relating to py2?
Shall I make a PR to remove that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I can not maintain Python 2.7 support.
Running/debugging on Python 2.7 is difficult today. So I will reject any Python 2 issues.
For example, actions/setup-python#672
Code cleanup for removing Python 2 support will be checked into msgpack 1.1.
For msgpack 1.0.6, I want to release RC as fast as possible.
I will update README/doc between 1.0.6rc and 1.0.6. PRs are welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, a 1.0.6 soon would be very welcome!