Skip to content

Add no-GIL interpreter support - #641

Merged
methane merged 18 commits into
msgpack:mainfrom
clin1234:nogil
Jun 2, 2026
Merged

Add no-GIL interpreter support#641
methane merged 18 commits into
msgpack:mainfrom
clin1234:nogil

Conversation

@clin1234

@clin1234clin1234 commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@clin1234
Add no-GIL interpreter support
6ced817
Add `pytest-run-parallel` as dependency, test no-GIL interpreters in CI, and
mark Cython module as safe for freethreaded interpreters.
@clin1234
Exclude PYTHON_GIL=0 for now
75cdd03
@clin1234
Lint
cafe4f0
@clin1234
Exclude PYTHON_GIL for now
3cc2a38
@clin1234clin1234 mentioned this pull request Jul 25, 2025
Closed
lysnikolaou
lysnikolaou reviewed Aug 6, 2025
View reviewed changes

@lysnikolaoulysnikolaou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clin1234! Thanks for working on this. I'm not the maintainer here, but I'm leaving a couple of comments to help move this forward.

Comment thread.github/workflows/wheel.yml Outdated
Comment threadtest/test_multithreading.py
lysnikolaou
lysnikolaou reviewed Aug 7, 2025
View reviewed changes

@lysnikolaoulysnikolaou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this so quickly @clin1234! Left some more comments on here. Hope these are helpful!

Comment thread.github/workflows/test.yml Outdated
Comment threadrequirements.txt Outdated
Comment threadtest/test_buffer.py
Comment threadtest/test_multithreading.py
@clin1234
Drop 3.8 support in test.yml
bf58057
@clin1234
Drop pytest-run-parallel as test requirement in requirements.txt
42f4cba
@clin1234
Separate C extension and fallback tests for GIL and no-GIL interpreters
d0797bd
@clin1234
Work around Windows wonkiness
79e5de1
On Windows, attempting to upgrade `pip` within CI always yields this:
```
Run pip install -U pip
Requirement already satisfied: pip in c:\hostedtoolcache\windows\python\3.10.11\x64\lib\site-packages (25.1.1)
Collecting pip
Downloading pip-25.2-py3-none-any.whl.metadata (4.7 kB)
Downloading pip-25.2-py3-none-any.whl (1.8 MB)
---------------------------------------- 1.8/1.8 MB 48.1 MB/s eta 0:00:00
Notice: A new release of pip is available: 25.1.1 -> 25.2
Notice: To update, run: python.exe -m pip install --upgrade pip
ERROR: To modify pip, please run the following command:
C:\hostedtoolcache\windows\Python\3.10.11\x64\python.exe -m pip install -U pip
Error: Process completed with exit code 1.
```
ferdnyc
ferdnyc reviewed Sep 5, 2025
View reviewed changes
Comment thread.github/workflows/test.yml Outdated
Comment thread.github/workflows/test.yml Outdated
methane
methane reviewed Sep 6, 2025
View reviewed changes
Comment thread.github/workflows/test.yml Outdated
clin1234and others added 3 commits September 9, 2025 17:05
@clin1234@ferdnyc
Fix minor YAML oops in .github/workflows/test.yml
9a7659f
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
@clin1234@ferdnyc
Fix minor YAML oops in .github/workflows/test.yml
e0e9b12
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
@clin1234
Drop spurious multhreading test
ccfd254
Per msgpack#641 (comment), sharing more than one `Packer` object is not supported.
ferdnyc
ferdnyc reviewed Sep 16, 2025
View reviewed changes
Comment thread.github/workflows/test.yml Outdated
khneal
khneal reviewed Sep 19, 2025
View reviewed changes
Comment thread.github/workflows/test.yml Outdated
@clin1234
clin1234 marked this pull request as ready for review September 27, 2025 17:22
@methane
methane merged commit 9de2fd9 into msgpack:mainJun 2, 2026
26 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methanemethanemethane left review comments
+3 more reviewers
@ferdnycferdnycferdnyc left review comments
@lysnikolaoulysnikolaoulysnikolaou left review comments
@khnealkhnealkhneal left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clin1234@methane@ferdnyc@lysnikolaou@khneal