Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Use standard built-it style formats - #37

Merged
mstum merged 1 commit into
mstum:masterfrom
0xced:StandardFormatIds
Apr 27, 2022
Merged

Use standard built-it style formats#37
mstum merged 1 commit into
mstum:masterfrom
0xced:StandardFormatIds

Conversation

@0xced

Copy link
Copy Markdown
Contributor

As defined in ECMA-376, 3rd Edition, Part 1, 18.8.30 numFmt (Number Format).

Some of these Ids can be interpreted differently, depending on the UI language of the implementing application.

This renders dates properly in Excel, matching the current computer locale settings.

For example, cell D5 in the "Test" worksheet of the sample app is correctly rendered as 26.04.2022 13:14 on a computer configured with a French (Switzerland) regional format. Without this change, the date was incorrectly displayed as 4.26.2022 13:14.

As defined in ECMA-376, 3rd Edition, Part 1, 18.8.30 numFmt (Number Format).
> Some of these Ids can be interpreted differently, depending on the UI language of the implementing application.
This renders dates properly in Excel, matching the current computer locale settings.
For example, cell D5 in the "Test" worksheet of the sample app is correctly rendered as `26.04.2022 13:14` on a computer configured with a French (Switzerland) regional format. Without this change, the date was incorrectly displayed as `4.26.2022 13:14`.
@mstum
mstum merged commit 8982017 into mstum:masterApr 27, 2022
@mstum

Copy link
Copy Markdown
Owner

Thanks!

@0xced
0xced deleted the StandardFormatIds branch April 27, 2022 07:17
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@0xced@mstum