feat(vllm): add support for image-to-text and video-to-text - #3729
Merged
Conversation
Related to #3670 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
marked this pull request as draft
October 4, 2024 15:30
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closes: #2318 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
commented
Oct 4, 2024
OwnerAuthor
Gotta try images on a GPU card. On CPU seems that generation is not broken at least, so should be good to merge and test on master |
mudler
marked this pull request as ready for review
October 4, 2024 17:29
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
commented
Oct 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
mudler
commented
Oct 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
siddimore pushed a commit
to siddimore/LocalAI
that referenced
this pull request
Oct 6, 2024
) * feat(vllm): add support for image-to-text Related to mudler#3670 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(vllm): add support for video-to-text Closes: mudler#2318 Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(vllm): support CPU installations Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(vllm): add bnb Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * chore: add docs reference Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * Apply suggestions from code review Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com> --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #3728
Closes: #2318
Closes: #3670
Also covers #3669 as should enable also Vision with Llama3.2 models
Notes for Reviewers
not tested yet on a GPU - just made sure it does not break generation by running vLLM in CPU-mode.
Signed commits