Skip to content

~lambdas: Add Raku language tests (formerly Perl 6) - #116

Merged
Danappelxx merged 1 commit into
mustache:masterfrom
softmoth:raku
Mar 29, 2021
Merged

Danappelxx merged 1 commit into
mustache:masterfrom
softmoth:raku

Conversation

@softmoth

Copy link
Copy Markdown
Contributor

Replaces #91. In the interim since that pull request was created, Perl 6 was renamed to Raku.

@softmoth softmoth mentioned this pull request Mar 18, 2021
@Danappelxx

Copy link
Copy Markdown
Collaborator

I don't know perl 6 very well, so unfortunately I can't review this PR for correctness. If someone else can review this, would be great.

Alternatively, we can wait until we have CI set up which can actually test the spec against your implementation.

@softmoth

softmoth commented Mar 18, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Danappelxx. Aside from the perl6 to raku rename, this is the same exact lambda tests that have been running on raku-Template-Mustache for years. So it is safe to use. I will push an update to raku-Template-Mustache to refer to the official repo w/ the raku naming as soon as I fix the sections.yml tests, which have two new checks that raku-Template-Mustache doesn't pass. But that should be considered independent of this PR.

Thank you!

Tim (aka softmoth)

@softmoth

softmoth commented Mar 19, 2021

Copy link
Copy Markdown
Contributor Author

I've pushed a new version that fixes the bug exposed by #114 (great to have new test cases) and includes this PR's version of ~lambdas.json. You can verify its success at https://travis-ci.org/softmoth/raku-Template-Mustache . Again, this has been tested thousands of times over the years by the Raku user base; the 'perl6' to 'raku' change is the only new thing. I hope that helps.

Kind regards,

Tim

@Danappelxx

Copy link
Copy Markdown
Collaborator

Fantastic! Thank you for your contribution.

@Danappelxx
Danappelxx merged commit 73a469c into mustache:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants