Uh oh!
There was an error while loading. Please reload this page.
Add Temporal support to SqlString.escape - #74
Open
pdeveltere wants to merge 1 commit into
Open
Conversation
Escaping a Temporal value (e.g. Temporal.Instant) currently falls through to objectToValues and produces broken SQL. Teach escape() about Temporal, mirroring the existing Date handling. - Instant / ZonedDateTime: absolute times, delegated to dateToString so the timeZone argument behaves exactly as it does for Date (ms precision). - PlainDateTime / PlainDate / PlainTime: wall-clock values, emitted verbatim as DATETIME / DATE / TIME literals (timeZone ignored). - Other Temporal types fall back to their ISO string. Temporal types are detected via Object.prototype.toString (Symbol.toStringTag), so the Temporal global is never referenced and the `node >= 0.6` engines range is unaffected. Adds tests (skipped when Temporal is unavailable) and README docs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escaping a Temporal value (e.g.
Temporal.Instant) currently falls through toobjectToValuesand produces broken SQL. This teachesescape()about Temporal, mirroring the existingDatehandling.Instant/ZonedDateTime: absolute times, delegated todateToStringso thetimeZoneargument behaves exactly as it does forDate(millisecond precision).PlainDateTime/PlainDate/PlainTime: wall-clock values, emitted verbatim asDATETIME/DATE/TIMEliterals (timeZoneignored).Temporal types are detected via
Object.prototype.toString(Symbol.toStringTag), so theTemporalglobal is never referenced and thenode >= 0.6engines range is unaffected — the branch simply never fires on runtimes without Temporal.Adds tests (skipped when Temporal is unavailable) and README docs.
npm testandeslint .both pass.