Skip to content

fix: rename the README of localops/ - #676

Merged
flub merged 1 commit into
n0-computer:mainfrom
amtoine:fix/bad-readme-name
Jan 5, 2023
Merged

fix: rename the README of localops/#676
flub merged 1 commit into
n0-computer:mainfrom
amtoine:fix/bad-readme-name

Conversation

@amtoine

@amtoine amtoine commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

hello there 👋

NOTE: this is about a very minor GitHub-rendering-related problem, so i thought opening a preliminary issue was a bit overkill 😌

while browsing you're repo, i've stumbled upon a minor typo in the iroh-localops/ directory:

  • the README is called REAME.md instead of README.md
  • it does not render properly as GitHub does not detect it

This PR simply renames iroh-localops/REAME.md to iroh-localops/README.md 😋

cheers 🎉

checking the work

on current main, i.e. 7921050

> find . -type f -name REAME.md
./iroh-localops/REAME.md

and now, i.e. on e1ad44b

> find . -type f -name REAME.md
# no output

@flub flub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amtoine

amtoine commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

glad you like the change 😌 😉

@amtoine

amtoine commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

ooo woopsie, i've received a notification about the failing test above 😮
is there anything i can do to solve this failing test? 😌

@flub
flub merged commit f4ba4cd into n0-computer:main Jan 5, 2023
@flub

flub commented Jan 5, 2023

Copy link
Copy Markdown
Collaborator

flaky test being mean. flaky tests are bad, one day it'll be fixed... one day

@amtoine
amtoine deleted the fix/bad-readme-name branch January 5, 2023 21:35
@amtoine

amtoine commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

flaky test being mean. flaky tests are bad, one day it'll be fixed... one day

i see 😋
one day... 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants