chore: rename the published distribution to nl2sql-engine - #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The PyPI distribution name
nl2sqlis already taken by an unrelated, abandonedproject (v0.0.0, author "Madhup Sukoon"). A trusted publisher cannot be configured
for a name we do not own, so the first release is blocked until the distribution is
renamed.
nl2sql-engineis available;nl2sql-apiandnl2sql-adapter-sdkare oursand are unchanged.
What actually changes
Only the PyPI distribution name. The Python import package stays
nl2sql.import nl2sql,from nl2sql.cli.main import ...,nl2sql.adapters.*— unchangedpackages/nl2sql/andpackages/nl2sql/src/nl2sql/— unchangednl2sqlconsole script — unchangednl2sql.adaptersentry-point group — unchanged(release-please owns versions and
CHANGELOG.md)Changed:
packages/nl2sql/pyproject.toml—name = "nl2sql"→nl2sql-enginepackages/api/pyproject.toml— dependencynl2sql~=0.1→nl2sql-engine~=0.1(constraint form kept)
release-please-config.json—"package-name"→nl2sql-engine(
.release-please-manifest.jsonis keyed by path".", so it needs no change)packages/nl2sql/src/nl2sql/cli/config.py—KNOWN_ADAPTERSvalues are passedstraight to
pip installbynl2sql install/setup/doctor, so they must bedistribution names:
nl2sql[postgres]→nl2sql-engine[postgres], and so onnl2sql/secrets/{factory,providers/*}.py— "Installnl2sql[aws]"-style hintspip install nl2sql...that installs from PyPIDeliberately not changed:
pip install -e "packages/nl2sql[postgres]"inCI,
CONTRIBUTING.md,docs/getting_started/{source,demo,docker}.mdandpackages/api/Dockerfile. Those are path-based editable/local installs pointingat a directory that has not moved.
The wheel-glob fix (the highest-risk item)
PyPI normalises
-to_in wheel filenames, so the built wheel becomesnl2sql_engine-0.1.0-py3-none-any.whl. The existing smoke-install globdist/nl2sql-*.whlno longer matches it — it would have matched nothing and let therelease gate pass while publishing an untested wheel. Fixed in both places:
.github/workflows/publish_pypi.yaml:39.github/workflows/test.yml:129Also: a missing human setup step
docs/development/releasing.mddocumented two one-time human setup steps. A thirdone is required and had blocked the pipeline in practice: Settings → Actions →
General → Workflow permissions → "Allow GitHub Actions to create and approve pull
requests". Without it
release_please.ymlcreates its branch and commit, thenfails with
GitHub Actions is not permitted to create or approve pull requests.The repo currently has
can_approve_pull_request_reviews: false.Verification
231 passed, 1 skipped, 47 deselected— unchanged, run twice28 passed— unchanged, run twicenl2sql_engine-0.1.0-py3-none-any.whlnl2sql-adapter-sdk-0.1.0,nl2sql-engine-0.1.0,nl2sql-api-0.1.0;import nl2sqlworks,nl2sql --helpworks,nl2sql list-adapterslists allfive adapters as Active;
nl2sql doctorrenders the newnl2sql-engine[...]install hints correctlypip show nl2sql-enginereports the new name;pip show nl2sqlreports not foundmkdocs build --strictclean; docs prose-path sweep clean