Skip to content

fix: ARenderer TypeError when href is undefined - #32

Merged
jsamr merged 2 commits into
native-html:mainfrom
arieloO:patch-1
Apr 14, 2026
Merged

fix: ARenderer TypeError when href is undefined#32
jsamr merged 2 commits into
native-html:mainfrom
arieloO:patch-1

Conversation

@arieloO

@arieloOarieloO commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Fixes TypeError on href.length when href is undefined

  • tests typeof href is string before reading its length

useNormalizedUrl can return undefined if it fails to parse absolute an url (see: normalizeResourceLocator.ts)

[TypeError: Cannot read property 'length' of undefined]

Fixes TypeError on `href.lenght` when href is undefined
- tests `typeof href` is string before reading its length
`useNormalizedUrl` can return `undefined` if it fails to parse absolute an url (see: normalizeResourceLocator.ts)
> `[TypeError: Cannot read property 'length' of undefined]`
@codecov

codecovBot commented Apr 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (5636b6e) to head (ed42508).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #32 +/- ##
=======================================
Coverage 98.65% 98.65% =======================================
Files 140 140 Lines 2083 2084 +1 Branches 633 634 +1 =======================================
+ Hits 2055 2056 +1 
Misses 27 27 Partials 1 1 
FlagCoverage Δ
css-processor100.00% <ø> (ø)
render97.85% <100.00%> (+<0.01%)⬆️
transient-render-engine98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

Hi @arieloO, thanks for the contribution!
I see that everything passes, I'll check the context of this implementation later today and will probably merge that

Comment threadpackages/render/src/renderers/ARenderer.tsx
- see fix: ARenderer TypeError when href is undefined (2c6f82a)
@arieloO
arieloO requested a review from jsamrApril 13, 2026 16:43
@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

LGTM, let's wait for @jsamr to give the final approve

@jsamr
jsamr merged commit 64410f9 into native-html:mainApr 14, 2026
8 checks passed
@arieloO

Copy link
Copy Markdown
ContributorAuthor

Hello @5ZYSZ3K and @jsamr,

Thank you for your reviews and for merging this.

Could you let me know when we might expect the next version to be out?

@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

Hello @5ZYSZ3K and @jsamr,

Thank you for your reviews and for merging this.

Could you let me know when we might expect the next version to be out?

As for me, it could go out even this week
I would wait for #34 to get merged (seems almost ready), and I still needs to do some adjustments to the readme, but it shouldn't take me long

@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

@arieloO are you okay with releasing next week? I see that #34 hasn't been merged yet; However if you need that, I think that I could get an alpha released over the weekend

@arieloO

Copy link
Copy Markdown
ContributorAuthor

@arieloO are you okay with releasing next week? I see that #34 hasn't been merged yet; However if you need that, I think that I could get an alpha released over the weekend

Thanks for the update @5ZYSZ3K !
Next week is fine for me 👍 otherwise an alpha is good too.

@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

@arieloO are you okay with releasing next week? I see that #34 hasn't been merged yet; However if you need that, I think that I could get an alpha released over the weekend

Thanks for the update @5ZYSZ3K ! Next week is fine for me 👍 otherwise an alpha is good too.

I see that #34 got merged, so I'll just prepare adjustements to the README, which I wanted to make, and I'll get that released this week

@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

@arieloO I released 1.0.3-alpha.0 - #36 isn't approved yet, and I didn't want you to wait. The 1.0.3 will be out after the merge of #36

@5ZYSZ3K

Copy link
Copy Markdown
Collaborator

@arieloO1.0.3 is out

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@arieloO@5ZYSZ3K@jsamr