Portals: logical parent vs rendering parent (M1-T14, closes #22) by ncdevshiv · Pull Request #102 · ncdevshiv/R2N

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv · 2026-08-31T01:50:41Z

What

Closes#22. React portals in the subset form:

<divclassName="modal-shell"></div><pclassName="logical">logical</p><Portaltarget="modal-shell"><b>portaled</b></Portal>

The portaled  renders insidemodal-shell (rendering parent) while identity, keys, and event dispatch stay logical.

ReactNode::Portal / RenderedNode::Portal: special-tag lowering; children rendered under the first Host with className == target.
Reconciliation stays logical: a per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids, preserved for old paths) lets the portal arm resolve its target's id regardless of traversal order; the old portal is located by path and its children matched by key — without this, every re-render created fresh portal nodes and left the old ones (the state-update test caught two 11).
Renderer tolerates sparse indices: portal children attach to a parent whose child count the diff doesn't know — patch creates clamp-append instead of panicking.
Missing target: children fall back to the logical position (no crash).

Verification

4 tests in tests/portals.rs: attach under the target, logical order of siblings, state updates propagate to portaled content (minimal SetText, no duplication), missing target safe. Suite 145 green; clippy -D warnings clean; fmt clean; audit green. Records: M1 14/18, overall 50/106.

- <Portal target=className> special tag; ReactNode::Portal IR + RenderedNode::Portal; children render under the first host element with that className — a different rendering parent - Reconciliation identity stays logical: per-pass resolve_portal_targets pre-scan + preassign_ids (path-order ids) so the target id is known regardless of traversal order; the OLD portal is located by path and its children matched by key — the naive old=None duplicated content on every update (caught by the state test: two 11) - Renderer: sparse patch indices (portal children attach to a parent whose child count is unknown) clamp-append instead of panic - Missing target: children fall back to the logical position (no crash) 4 tests in tests/portals.rs; suite 145 green; clippy/fmt/audit clean. Records: M1 14/18 in progress, 50/106. Closes#22

ncdevshiv merged commit 7d9b9de into mainAug 31, 2026
2 checks passed

ncdevshiv deleted the feat/m1-t14-portals branch August 31, 2026 01:55