Remove the nightly feature and clean some parts of the code - #9
Open
Kerollmops wants to merge 5 commits into
Open
Remove the nightly feature and clean some parts of the code#9Kerollmops wants to merge 5 commits into
Kerollmops wants to merge 5 commits into
Conversation
|
I'm evaluating this crate and I'm also interested in using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the
const_fn_traitfeature is stable, we no longer need the nightly feature. I, therefore, remove theINSTRUMENTED_SYSTEMconst in favor of theStatsAlloc::systemconst method. This is a breaking change. I removed one useless test related to this constant variable.Questions
Ordering::Relaxedinstead of theSeqCst. Operations will never be ordered anyway, so let's get more speed there.