Skip to content

Spec pointer to have better support for omit empty - #7

Open
henderiw wants to merge 5 commits into
nephio-project:mainfrom
nokia:capacity-pointer
Open

Spec pointer to have better support for omit empty#7
henderiw wants to merge 5 commits into
nephio-project:mainfrom
nokia:capacity-pointer

Conversation

@henderiw

Copy link
Copy Markdown
Contributor

using pointer for empty values instead of using default go values.

@nephio-prow

Copy link
Copy Markdown
Contributor

Hi @henderiw. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric

Copy link
Copy Markdown
Member

/ok-to-test

@johnbelamaricjohnbelamaric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the complete files again, it's hard to review. It would be best if you can rebase so we only see the pointer changes

Comment threadhack/boilerplate.go.txt Outdated
Comment threadnf_requirements/v1alpha1/capacity_interfaces.go Outdated
@gvbalaji

Copy link
Copy Markdown

Looks like a rebase is needed

@henderiwhenderiw reopened this Apr 25, 2023
@nephio-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@nephio-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henderiw

Copy link
Copy Markdown
ContributorAuthor

/retest

@gvbalajigvbalaji left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do away with some of the getters but no harm. Aked a question on MaxNFConnections, other than that
/approve.

Comment threadnf_requirements/v1alpha1/capacity_types.go
@gvbalaji

Copy link
Copy Markdown

rebase needed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@henderiw@johnbelamaric@gvbalaji