Skip to content

Trying to contribute, how do you build a linkable lib? #509

Open
Open
Trying to contribute, how do you build a linkable lib?#509

Description

@colmben
colmben
opened on Sep 13, 2019

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Performance issue
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Current behavior

I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:

"angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",

)

I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.

If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.

I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.

Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.

Environment

Angular-Token version: 7.1.0-rc.0
Angular version: 8.2.2

Bundler

  • Angular CLI (Webpack)
  • Webpack
  • SystemJS

Browser:

  • Chrome (desktop) version XX
  • Chrome (Android) version XX
  • Chrome (iOS) version XX
  • Firefox version XX
  • Safari (desktop) version XX
  • Safari (iOS) version XX
  • IE version XX
  • Edge version XX

Others:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
     blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Trying to contribute, how do you build a linkable lib? · Issue #509 · neroniaky/angular-token · GitHub
    Skip to content
    Trying to contribute, how do you build a linkable lib? #509
    Open
    Open
    Trying to contribute, how do you build a linkable lib?#509
    Description
    @colmben
    colmben
    opened on Sep 13, 2019
    I'm submitting a...
    •  Regression (a behavior that used to work and stopped working in a new release)
    •  Bug report
    •  Performance issue
    •  Feature request
    •  Documentation issue or request
    •  Other... Please describe:
    Current behavior
    I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:
    "angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",
    )
    I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.
    If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.
    I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.
    Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.
    Environment
    Angular-Token version: 7.1.0-rc.0
    
Angular version: 8.2.2
    Bundler
    •  Angular CLI (Webpack)
    •  Webpack
    •  SystemJS
    Browser:
    •  Chrome (desktop) version XX
    •  Chrome (Android) version XX
    •  Chrome (iOS) version XX
    •  Firefox version XX
    •  Safari (desktop) version XX
    •  Safari (iOS) version XX
    •  IE version XX
    •  Edge version XX
    Others:
    Metadata
    Metadata
    Assignees
    No one assigned
      Labels
      No labels
      No labels
      Projects
      No projects
      Milestone
      No milestone
      Relationships
      None yet
      Development
      No branches or pull requests
      Issue actions
      
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Trying to contribute, how do you build a linkable lib? · Issue #509 · neroniaky/angular-token · GitHub
      Skip to content
      Trying to contribute, how do you build a linkable lib? #509
      Open
      Open
      Trying to contribute, how do you build a linkable lib?#509
      Description
      @colmben
      colmben
      opened on Sep 13, 2019
      I'm submitting a...
      •  Regression (a behavior that used to work and stopped working in a new release)
      •  Bug report
      •  Performance issue
      •  Feature request
      •  Documentation issue or request
      •  Other... Please describe:
      Current behavior
      I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:
      "angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",
      )
      I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.
      If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.
      I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.
      Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.
      Environment
      Angular-Token version: 7.1.0-rc.0
      
Angular version: 8.2.2
      Bundler
      •  Angular CLI (Webpack)
      •  Webpack
      •  SystemJS
      Browser:
      •  Chrome (desktop) version XX
      •  Chrome (Android) version XX
      •  Chrome (iOS) version XX
      •  Firefox version XX
      •  Safari (desktop) version XX
      •  Safari (iOS) version XX
      •  IE version XX
      •  Edge version XX
      Others:
      Metadata
      Metadata
      Assignees
      No one assigned
        Labels
        No labels
        No labels
        Projects
        No projects
        Milestone
        No milestone
        Relationships
        None yet
        Development
        No branches or pull requests
        Issue actions
        
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Trying to contribute, how do you build a linkable lib? · Issue #509 · neroniaky/angular-token · GitHub
        Skip to content
        Trying to contribute, how do you build a linkable lib? #509
        Open
        Open
        Trying to contribute, how do you build a linkable lib?#509
        Description
        @colmben
        colmben
        opened on Sep 13, 2019
        I'm submitting a...
        •  Regression (a behavior that used to work and stopped working in a new release)
        •  Bug report
        •  Performance issue
        •  Feature request
        •  Documentation issue or request
        •  Other... Please describe:
        Current behavior
        I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:
        "angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",
        )
        I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.
        If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.
        I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.
        Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.
        Environment
        Angular-Token version: 7.1.0-rc.0
        
Angular version: 8.2.2
        Bundler
        •  Angular CLI (Webpack)
        •  Webpack
        •  SystemJS
        Browser:
        •  Chrome (desktop) version XX
        •  Chrome (Android) version XX
        •  Chrome (iOS) version XX
        •  Firefox version XX
        •  Safari (desktop) version XX
        •  Safari (iOS) version XX
        •  IE version XX
        •  Edge version XX
        Others:
        Metadata
        Metadata
        Assignees
        No one assigned
          Labels
          No labels
          No labels
          Projects
          No projects
          Milestone
          No milestone
          Relationships
          None yet
          Development
          No branches or pull requests
          Issue actions
          
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Trying to contribute, how do you build a linkable lib? · Issue #509 · neroniaky/angular-token · GitHub
          Skip to content
          Trying to contribute, how do you build a linkable lib? #509
          Open
          Open
          Trying to contribute, how do you build a linkable lib?#509
          Description
          @colmben
          colmben
          opened on Sep 13, 2019
          I'm submitting a...
          •  Regression (a behavior that used to work and stopped working in a new release)
          •  Bug report
          •  Performance issue
          •  Feature request
          •  Documentation issue or request
          •  Other... Please describe:
          Current behavior
          I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:
          "angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",
          )
          I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.
          If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.
          I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.
          Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.
          Environment
          Angular-Token version: 7.1.0-rc.0
          
Angular version: 8.2.2
          Bundler
          •  Angular CLI (Webpack)
          •  Webpack
          •  SystemJS
          Browser:
          •  Chrome (desktop) version XX
          •  Chrome (Android) version XX
          •  Chrome (iOS) version XX
          •  Firefox version XX
          •  Safari (desktop) version XX
          •  Safari (iOS) version XX
          •  IE version XX
          •  Edge version XX
          Others:
          Metadata
          Metadata
          Assignees
          No one assigned
            Labels
            No labels
            No labels
            Projects
            No projects
            Milestone
            No milestone
            Relationships
            None yet
            Development
            No branches or pull requests
            Issue actions
            
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Trying to contribute, how do you build a linkable lib? · Issue #509 · neroniaky/angular-token · GitHub
            Skip to content
            Trying to contribute, how do you build a linkable lib? #509
            Open
            Open
            Trying to contribute, how do you build a linkable lib?#509
            Description
            @colmben
            colmben
            opened on Sep 13, 2019
            I'm submitting a...
            •  Regression (a behavior that used to work and stopped working in a new release)
            •  Bug report
            •  Performance issue
            •  Feature request
            •  Documentation issue or request
            •  Other... Please describe:
            Current behavior
            I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:
            "angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",
            )
            I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.
            If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.
            I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.
            Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.
            Environment
            Angular-Token version: 7.1.0-rc.0
            
Angular version: 8.2.2
            Bundler
            •  Angular CLI (Webpack)
            •  Webpack
            •  SystemJS
            Browser:
            •  Chrome (desktop) version XX
            •  Chrome (Android) version XX
            •  Chrome (iOS) version XX
            •  Firefox version XX
            •  Safari (desktop) version XX
            •  Safari (iOS) version XX
            •  IE version XX
            •  Edge version XX
            Others:
            Metadata
            Metadata
            Assignees
            No one assigned
              Labels
              No labels
              No labels
              Projects
              No projects
              Milestone
              No milestone
              Relationships
              None yet
              Development
              No branches or pull requests
              Issue actions
              
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Trying to contribute, how do you build a linkable lib? · Issue #509 · neroniaky/angular-token · GitHub
              Skip to content
              Trying to contribute, how do you build a linkable lib? #509
              Open
              Open
              Trying to contribute, how do you build a linkable lib?#509
              Description
              @colmben
              colmben
              opened on Sep 13, 2019
              I'm submitting a...
              •  Regression (a behavior that used to work and stopped working in a new release)
              •  Bug report
              •  Performance issue
              •  Feature request
              •  Documentation issue or request
              •  Other... Please describe:
              Current behavior
              I am trying to test a small change that will enable the forgotten password flow to work correctly. To do that I am trying to link to a fork on github (using something like this in my package.json:
              "angular-token": "git+https://github.com/colmben/angular-token.git#fixBranch",
              )
              I have tried a few different ways but I can't get the repo to build in a way that is linkable like this, due to the way the repo is structured with the example app in root and the actual lib in projects/angular-token.
              If I build:lib, I get files in a root dist folder. I can commit this (which is the way to create a repo that is directly linkable as above) but when I npm install the repo it gives me an entry for angular-token-app instead of angular-token and that entry doesn't seem to give me access to AngularTokenService/AngularTokenModule in app.modules.
              I have gone as far as using git subtree split to create a repo from /projects/angular-token, with the dist copied in from the root dir. This actually works locally but Heroku (where I am trying to test the issue) says it can't resolve angular-token.
              Could any share how they are testing changes? The fix is only testable on a real server so I can't just play around with the local node_modules.
              Environment
              Angular-Token version: 7.1.0-rc.0
              
Angular version: 8.2.2
              Bundler
              •  Angular CLI (Webpack)
              •  Webpack
              •  SystemJS
              Browser:
              •  Chrome (desktop) version XX
              •  Chrome (Android) version XX
              •  Chrome (iOS) version XX
              •  Firefox version XX
              •  Safari (desktop) version XX
              •  Safari (iOS) version XX
              •  IE version XX
              •  Edge version XX
              Others:
              Metadata
              Metadata
              Assignees
              No one assigned
                Labels
                No labels
                No labels
                Projects
                No projects
                Milestone
                No milestone
                Relationships
                None yet
                Development
                No branches or pull requests
                Issue actions