Fix dark theme select popups

[Finesssee]

Summary

• stop forcing the shared native select control into the light color scheme
• apply explicit dark native select/option colors under the dark theme
• preserve the existing light popup behavior with an explicit light color scheme

Fixes #470

Validation

• reproduced on the exact shipped v0.56.8 Windows build with CUA: the dark Settings surface opened the native select popup with a white background and low-contrast option text
• pnpm --dir apps/desktop-tauri test: 59 files, 343 tests passed
• pnpm --dir apps/desktop-tauri run build: passed, including locale drift check and TypeScript build
• git diff --check: passed
• fresh pnpm --dir apps/desktop-tauri run tauri:build:debug was attempted for post-fix CUA proof. The frontend build completes, but Rust dependency build scripts fail because this machine resolves link.exe to C:\Program Files\Git\usr\bin\link.exe instead of the MSVC linker. A fresh desktop binary could therefore not be produced locally for post-fix CUA capture.

UI proof note

The pre-fix native WebView2 popup was captured on Windows. The fix is limited to the theme-specific CSS controlling that same native select. Hosted Windows CI should provide the fresh build gate; post-fix native-popup CUA is the only local check blocked by the machine linker configuration.

Summary by CodeRabbit

• Style
  • Improved dark-theme styling for select controls, including provider and settings selectors, with darker option backgrounds and clearer selected-option accents.
  • Preserved the light-theme appearance, including white option backgrounds, across select controls.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c7b05b3c-c732-46a7-973c-0605ddb80be3

📥 Commits

Reviewing files that changed from the base of the PR and between 3e8b873 and dbe16dd.

📒 Files selected for processing (1)

• apps/desktop-tauri/src/styles.css

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/desktop-tauri/src/styles.css

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

📝 Walkthrough

Walkthrough

Select controls now share explicit dark and light theme styling. Provider and settings dropdowns use theme-appropriate option backgrounds, text colors, and checked-option accents.

Changes

Select theme styling

Layer / File(s)	Summary
Theme-specific select rules apps/desktop-tauri/src/styles.css	Dark and light theme rules now apply to .select, .provider-detail-select, and .settings-select. Checked options use the accent background with white text.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to dbe16

No merge-blocking risk remains from the supplied change context.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: fixing dark-theme select popups.
Linked Issues check	✅ Passed	Issue #470 requires readable native dropdown popups in dark theme and preserved light-theme behavior. The PR removes the shared forced color-scheme: light, applies color-scheme: dark plus dark tex…
Out of Scope Changes check	✅ Passed	The whole-PR evidence shows changes only in apps/desktop-tauri/src/styles.css. The changes extend native select theme rules and remove the conflicting forced light scheme. These changes directly sup…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-470-dark-select

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Finesssee]

Maintainer validation + scope fix for #470.

Independently checked the reported control: the screenshot path (Settings → Providers → Tray display → Menu bar and floating bar metric) resolves to MenuBarMetricSection, whose <select> is className="provider-detail-select" — not .select. The theme rules added earlier only covered .select, so the exact popup from the report was still untargeted. Usage & Spend → Cost summary style is another live native select (className="settings-select") with no theme handling.

Extended the existing theme-specific select rules to also cover .provider-detail-select and .settings-select:

• dark: explicit color-scheme: dark; option background var(--app-bg) + text var(--text-primary); option:checked var(--accent) on white
• light: explicit color-scheme: light; option white background + var(--text-primary) text; option:checked var(--accent) on white

No layout or closed-control changes; only native popup color-scheme and option colors.

Validation:

• pnpm test: 59 files / 343 tests passed
• pnpm run build: passed (locale drift + tsc --noEmit + vite build)
• git diff --check: clean

Head: dbe16ddb0 (fast-forward on fix/issue-470-dark-select).