Uh oh!
There was an error while loading. Please reload this page.
fix: remove deprecated decorator passing in tsconfig path hooks - #2023
Closed
ttshivers wants to merge 1 commit into
Closed
fix: remove deprecated decorator passing in tsconfig path hooks#2023ttshivers wants to merge 1 commit into
ttshivers wants to merge 1 commit into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ttshiversforce-pushed
the
fix-typescript-5
branch
2 times, most recently
from
April 15, 2023 19:54
4ad6f34 to
521dc06Comparettshivers
commented
Apr 15, 2023
Author
I've removed the commit to update typescript to v5 in this commit and just addressed the deprecated decorator passing instead for this PR. |
Decorators are now placed on `modifiers` on TypeScript's syntax trees. Passing decorators separately has been deprecated since v4.8 and removed completely in v5. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#decorators-are-placed-on-modifiers-on-typescripts-syntax-treesmicrosoft/TypeScript#49089
kamilmysliwiec
commented
May 23, 2023
Member
Let's track this here #2092 |
aashir-khan
commented
Nov 28, 2023
@kamilmysliwiec did that PR address the deprecation? I seems like it addressed something else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
nest-cli passes decorators to
updateImportDeclarationwhich has been deprecated since typescript v4.8 now that decorators are placed onmodifiersin the syntax tree.https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#decorators-are-placed-on-modifiers-on-typescripts-syntax-trees
nest-cli fails to build with typescript 5 with errors like https://github.com/nestjs/nest-cli/pull/1986/checks?check_run_id=12600352096
Issue Number: N/A
What is the new behavior?
nest-cli no longer emits deprecation warnings and also now successfully builds with typescript 5
Does this PR introduce a breaking change?
Other information
Decorators are now placed on
modifierson TypeScript's syntax trees.Passing decorators separately has been deprecated since v4.8 and removed completely in v5.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#decorators-are-placed-on-modifiers-on-typescripts-syntax-trees
microsoft/TypeScript#49089