Document dashboard CSP environment variables - #965
Conversation
|
@maxbrc is attempting to deploy a commit to the NetBird GmbH Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Dashboard Variables table documents three environment variables for dashboard Content Security Policy configuration. The entries cover extra origins, OIDC discovery, and the OIDC discovery timeout. ChangesDashboard CSP documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates Dashboard CSP environment-variable documentation without changing runtime behavior. No current merge-readiness risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds
NETBIRD_CSP,NETBIRD_CSP_OIDC_DISCOVERYandNETBIRD_CSP_OIDC_DISCOVERY_TIMEOUTto the Dashboard Variables table.NETBIRD_CSPalready exists but was undocumented. The other two come fromnetbirdio/dashboard#789, which adds the IdP's OIDC endpoint origins to the
CSP
connect-src. This is needed when the token or JWKS endpoints sit on adifferent host than the issuer (like the issue netbirdio/dashboard#690).
Depends on netbirdio/dashboard#789.
(Sorry for the merge commit, I assume you squash anyways)
Summary by CodeRabbit