Contributors Guide - #966
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR adds contribution documentation, navigation links, repository workflows, and policy guidance. It updates README examples for Next.js/MDX. It also measures announcement banner height with ChangesDocumentation and announcement updates
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documented changes and banner sizing update have no supported unresolved merge risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
src/pages/contribute/development.mdxtypescript-eslint does not support TS 7.0. Oops! Something went wrong! :( ESLint: 9.39.5 Error: typescript-eslint does not support TS 7.0. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the docs at dawn Comment |
…ites" This reverts commit e418606.
Contributors Guide
What changed
Adds a contributor guide at
/contributeso people can find the right repository, prepare a change, and understand what to expect from review without piecing the process together across projects.The guide covers first contributions, repository ownership, local development and testing, pull requests, and contribution policies. It keeps repository-specific instructions authoritative rather than applying the core project's rules to every NetBird repository. It also explains generated-file boundaries, private vulnerability reporting, and how to contain tests that alter networking or create live resources.
The new pages appear in the docs sidebar. The README points to the guide and updates the local setup instructions and several MDX examples.
This also includes the announcement-banner height fix found during mobile review. The header now follows the banner's rendered height instead of assuming it stays on one line, so a wrapped announcement does not cover the mobile navigation. Wide repository tables scroll within their own focusable regions.
Related website change
Companion branch: Contribution Onboarding.
The website is a short introduction that links into this handbook, not a second copy of it. Publish these docs before the website change goes live so its contribution links have working destinations. This docs change does not depend on the website being deployed.
Verification
npm ciandnpm run buildpassed with Node.js 22.23.1.npm run lint:mdxpassed for 298 MDX files./contributeroutes returned HTTP 200 from the local production build. The combined site/docs check verified 50 unique contributor route and anchor targets.git diff --cached --checkpassed.The broad
npm run lintcommand still reports 15 errors and 8 warnings. The navigation finding matches the unchanged code in the base revision; the remaining findings are in untouched files. No new lint findings were identified. The pinned dependency install reports 22 audit advisories; this change does not modify dependencies or the lockfile.Earlier preview review covered desktop and mobile layouts, light and dark themes, keyboard table scrolling, and opening the mobile menu with a wrapped announcement. Fresh browser capture was unavailable during this final check; build and HTTP/link checks were rerun. This is not a fresh runtime test of every downstream development command described in the handbook.
Summary by CodeRabbit
New Features
Documentation