Skip to content

[doc] Explain custom domain deletion requirements - #972

Open
mlsmaycon wants to merge 1 commit into
mainfrom
docs/custom-domain-deletion-guard
Open

[doc] Explain custom domain deletion requirements#972
mlsmaycon wants to merge 1 commit into
mainfrom
docs/custom-domain-deletion-guard

Conversation

@mlsmaycon

@mlsmaycon mlsmaycon commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Custom domains now remain registered while services depend on them. Explain that administrators must delete or move every dependent service, including disabled services and services using subdomains, before removing the domain.

Document the HTTP 412 response and that a refused deletion preserves the domain and services without recording a deletion event.

Validation: npm run lint:mdx passed for all 296 pages and npm run build completed successfully.

Companion implementation PR: netbirdio/netbird#7515

Summary by CodeRabbit

  • Documentation
    • Updated custom-domain deletion guidance to clarify that all services using the domain or its subdomains—including disabled services—must be deleted or moved first.
    • Documented that deletion is refused with an HTTP 412 error while services still reference the domain.

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 11, 2026 4:50pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8fe40d5e-2f82-4f78-9588-3a87ea1ee399

📥 Commits

Reviewing files that changed from the base of the PR and between b046b65 and 0ce05a3.

📒 Files selected for processing (1)
  • src/pages/manage/reverse-proxy/custom-domains.mdx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The custom domain deletion documentation now describes service dependencies, disabled services, and the HTTP 412 Precondition Failed response.

Changes

Custom domain deletion

Layer / File(s) Summary
Document deletion requirements
src/pages/manage/reverse-proxy/custom-domains.mdx
The section requires users to delete or move services that use the domain or its subdomains. It includes disabled services and documents the HTTP 412 Precondition Failed response.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 0ce05

The deletion guidance is updated without introducing runtime or deployment risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation change about custom domain deletion requirements.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/custom-domain-deletion-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the domain guide,
Disabled services now cannot hide.
Dependencies clear the way,
Four-one-two guards the day.
The proxy path is tidy and wide.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant