Uh oh!
There was an error while loading. Please reload this page.
Configure headers in response setup - #153
Conversation
mabar
commented
Mar 18, 2019
I am not sure how to fix tests. I tested it in my app and it should work properly. |
c23f7b6 to
b834b0dCompare8fd7f28 to
51a304fCompare1718bd2 to
9b138d0Comparemabar
commented
Jul 6, 2019
@dg Ready |
dg
commented
Jul 7, 2019
I'm afraid this is a BC break, which is not suitable for the patch version. |
mabar
commented
Jul 7, 2019
I thinked about it too. It should be BC break only in case that someone depends on fact that headers are sent and Response is not instantiated by user's app. nette\application users are ok, only users of standalone nette/http should be affected and just in case they send response incorrectly without Response class. As far as I know, Apitte is the only http-related nette extension, which is (almost) completely separated from nette/http and it will be not affected by this change until next version. Do you know an other case which could be problematic? This PR is non-blocking for me, so it could wait. Just an architectural problem. |
mabar
commented
Jul 7, 2019
Maybe a compatibility-mode, which would be enabled by default? It would just initialize service in initialize() method, if enabled. Something like this |
dg
commented
Jul 7, 2019
In case it is non-blocking for you, I will postpone it to 3.1. |
ok, thanks |
f843ac1 to
a472b8dCompare8b44821 to
052190cCompareb1f6bb5 to
518f8e5Compare7ae9bc0 to
0c8dfceCompareab1b02a to
a2d51faCompare9ff6baa to
420d9a2Comparebda06a4 to
e791a00Comparef7f33af to
94c20b7Comparefd982d7 to
be6a248Comparemabar
commented
May 19, 2021
@dg Would this change be acceptable for v4.0? Response will not sent headers directly anyway and it would be helpful if it didn't interfere with other http libraries. |
Moved headers configuration from initialize() method of DIC to Response service setup.
Useful for applications with multiple http layer implementations (we use psr-7 in Apitte). It should prevent mixing headers from nette/http if not used for current request