Request: added withUrl()

[JanTvrdik]

It's often useful (e.g. in tests) to modify URL inside httpRequest. Doing this is really annoying because Request has lot of constructor parameters. The naming (with*) is based on PSR-7.

What do you think about this idea? Tests are currently missing.

[enumag]

Can you show an example of a test where you need this? I never needed anything like it, instead it would be really benefitial for my tests if Request would not be a service (and Response as well for that matter).

Also I certainly wouldn't like this method in the IRequest interface.

[fprochazka]

@JanTvrdik I like the idea, doing this every time is tedious.

[JanTvrdik]

instead it would be really benefitial for my tests if Request would not be a service

Feel free to join the relevant discussion.

---

Can you show an example of a test where you need this?

Sorry, I have a really bad memory. I found the code I have written (6 days ago) and the withUrl method would not help in that case. The reason why I brought it up today is because I was creating a draft for a router where the method would be helpful.

class DevRouter implementsApplication\IRouter
{
// *.signaly.cz -> *.signaly.l // *.signaly.cz -> localhost/signaly/www/*publicfunction__construct($fromMask, $toMask, Application\IRouter$innerRouter)
{
$this->fromMask = $fromMask;
$this->toMask = $toMask;
$this->innerRouter = $innerRouter;
}
publicfunctionmatch(Nette\Http\IRequest$httpRequest)
{
$fixedUrl = $this->transformIn($httpRequest->url);
$fixedHttpRequest = $httpRequest->withUrl($fixedUrl); // <-- THIS IS THE LINEreturn$this->innerRouter->match($fixedHttpRequest);
}
publicfunctionconstructUrl(Request$appRequest, Nette\Http\Url$refUrl)
{
$url = $this->innerRouter->constructUrl($appRequest, $refUrl);
$fixedUrl = $this->transformOut($url);
return$fixedUrl;
}
}

[enumag]

In my opinion you should just write a static helper method cloneRequestWithUrl($request, $url) outside of this class.